Preserve build tags #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Find the build tags (`go build -tags a,b,c`) from the `go version -m` output and store them in the introspected go binary information. This information will later be used to preserve the build tags while upgrading a binary.
`go-global-update` is now aware of build tags (`go install -tags a,b,c ...`) that were used to install the binary. It will reuse the same build tags when updating/reinstalling packages. Fixes #28
`ioutil.TempDir` is deprecated. `os.MkdirTemp` should be used instead.
Gelio
force-pushed
the
preserve-build-tags
branch
from
f5cf546 to
36cb606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-global-updateis now aware of build tags (go install -tags a,b,c...) that were used to install the binary. It will reuse the tags when updating/reinstalling packages.This PR includes the feature, as well as unit and integration tests for it.
Fixes #28