New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent button click from reloading page #20

Merged

ivanvs merged 1 commit into GenFirst:master from justnorawr:patch-1

Apr 1, 2018

Contributor

justnorawr commented Mar 31, 2018

This was causing issues for me during development, the page would reload before the getRequestToken calls would finish causing the popup to have a blank white page.

I think this may fix this issue: #19


          prevent button click from reloading page

4d81d5f

coveralls commented Mar 31, 2018

Coverage decreased (-0.3%) to 16.667% when pulling 4d81d5f on nichcurtis:patch-1 into fc01dbc on GenFirst:master.

4 similar comments

coveralls commented Mar 31, 2018

Coverage decreased (-0.3%) to 16.667% when pulling 4d81d5f on nichcurtis:patch-1 into fc01dbc on GenFirst:master.

coveralls commented Mar 31, 2018

Coverage decreased (-0.3%) to 16.667% when pulling 4d81d5f on nichcurtis:patch-1 into fc01dbc on GenFirst:master.

coveralls commented Mar 31, 2018

Coverage decreased (-0.3%) to 16.667% when pulling 4d81d5f on nichcurtis:patch-1 into fc01dbc on GenFirst:master.

coveralls commented Mar 31, 2018

Coverage decreased (-0.3%) to 16.667% when pulling 4d81d5f on nichcurtis:patch-1 into fc01dbc on GenFirst:master.

Contributor

ivanvs commented Apr 1, 2018 •

edited

Loading

Thank you for your valuable contribution.

I will publish new version of library in next few days. I want to add one more small feature, and when that is finished we will have new version.

ivanvs merged commit 307fd4f into GenFirst:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet