Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include yield fee mint limit in asset liquidation balance #114

Conversation

trmid
Copy link
Member

@trmid trmid commented Jun 22, 2024

When liquidating assets (not shares), the mint limit should be considered if a yield fee is in place when calculating the liquid balance since transferTokensOut enforces this limit on fee accrual. This ensures that the value being returned by liquidatableBalanceOf can be passed to transferTokensOut even when approaching the mint limit.

Copy link

LCOV of commit c33bfa6 during coverage #582

Summary coverage rate:
  lines......: 99.6% (242 of 243 lines)
  functions..: 100.0% (65 of 65 functions)
  branches...: no data found

Files changed coverage rate:
                              |Lines       |Functions  |Branches    
  Filename                    |Rate     Num|Rate    Num|Rate     Num
  ==================================================================
  src/PrizeVault.sol          |99.5%    205| 100%    51|    -      0

@trmid trmid requested a review from asselstine June 27, 2024 17:23
@trmid trmid merged commit d888632 into fix-review Jun 28, 2024
2 checks passed
@trmid trmid deleted the gen-1779-88-consider-yield-fee-amount-with-mintlimit-when-returning branch July 15, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants