Implemented safety mechanisms around vault hooks #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asselstine
commented
Aug 15, 2023
asselstine
commented
- Hooks have gas limits
- Hook failures are recorded during batch calls, so they can be avoided.
PierrickGT
suggested changes
Aug 15, 2023
src/Vault.sol
Outdated
Comment on lines
101
to
105
| error BeforeClaimPrizeFailed(bytes reason); | ||
|
|
||
| error AfterClaimPrizeFailed(bytes reason); | ||
|
|
||
| uint256 constant HOOK_GAS = 150_000; |
| @@ -199,6 +205,13 @@ contract Vault is ERC4626, ERC20Permit, ILiquidationSource, Ownable { | |||
| */ | |||
| event RecordedExchangeRate(uint256 exchangeRate); | |||
|
|
|||
| event ClaimFailed( | |||
| @@ -1038,6 +1058,15 @@ contract Vault is ERC4626, ERC20Permit, ILiquidationSource, Ownable { | |||
| } | |||
|
|
|||
| /* ============ Claim Functions ============ */ | |||
| function claimPrize( | |||
| address _winner, | ||
| uint8 _tier, | ||
| uint32 _prizeIndex, | ||
| uint96 _fee, | ||
| address _feeRecipient | ||
| ) internal returns (uint256) { | ||
| ) external returns (uint256) { |
There was a problem hiding this comment.
Should be internal no? Or even private.
There was a problem hiding this comment.
It has to be external because of the try catch. Kind of a weird trick
| @@ -1239,4 +1271,9 @@ contract Vault is ERC4626, ERC20Permit, ILiquidationSource, Ownable { | |||
| function _setYieldFeeRecipient(address yieldFeeRecipient_) internal { | |||
| _yieldFeeRecipient = yieldFeeRecipient_; | |||
| } | |||
|
|
|||
| modifier onlyClaimer() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.