Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session.virtualfile_in: Remove parameter 'required_z' and add 'ncols' #3369

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

seisman
Copy link
Member

@seisman seisman commented Aug 4, 2024

A different implementation to address the points raised in #2744.

@seisman seisman force-pushed the refactor/virtualfile_in branch 2 times, most recently from f1e6aca to 9e78da0 Compare August 4, 2024 11:01
@seisman seisman changed the title Session.virtualfile_in: Remove the extra_arrays parameter Refactor Session.virtualfile_in, removing 'extra_arrays'/'required_z' and add 'required_cols' Aug 4, 2024
@seisman seisman force-pushed the refactor/virtualfile_in branch 2 times, most recently from 2a1db22 to b33476c Compare August 4, 2024 12:39
@seisman seisman added this to the 0.14.0 milestone Aug 5, 2024
@seisman seisman removed this from the 0.14.0 milestone Sep 5, 2024
@seisman seisman force-pushed the refactor/data_kind branch from bca59f5 to 808755d Compare October 3, 2024 09:21
@seisman seisman changed the base branch from refactor/data_kind to main October 3, 2024 09:26
@seisman seisman self-assigned this Oct 30, 2024
@seisman seisman changed the title Refactor Session.virtualfile_in, removing 'extra_arrays'/'required_z' and add 'required_cols' Session.virtualfile_in: Remove parameter 'required_z' and add 'ncols' Mar 5, 2025
@seisman seisman force-pushed the refactor/virtualfile_in branch from d7ca533 to feddd9c Compare March 5, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant