Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Install dvc via uv in the "GMT Tests" workflow #3695

Merged
merged 11 commits into from
Dec 19, 2024
Merged

CI: Install dvc via uv in the "GMT Tests" workflow #3695

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3422b1d
Do not install dvc from conda-forge
seisman Dec 18, 2024
bfd9289
Use iterative/setup-dvc
seisman Dec 18, 2024
b5a5b1c
Use pip to install dvc
seisman Dec 18, 2024
e66e892
Install dvc via choco on Windows
seisman Dec 18, 2024
848dd8c
Install dvc via winget on Windows
seisman Dec 18, 2024
d86491b
Revert "Install dvc via winget on Windows"
seisman Dec 18, 2024
75af0a8
Revert "Install dvc via choco on Windows"
seisman Dec 18, 2024
aa06f58
See if uv is faster
seisman Dec 18, 2024
83bb2d7
Check if it works well with Python 3.13
seisman Dec 18, 2024
86f51c4
Revert "Check if it works well with Python 3.13"
seisman Dec 18, 2024
71df56a
Install dvc in an isolated env
seisman Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/ci_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ jobs:
xarray${{ matrix.xarray-version }}
netCDF4
packaging
dvc
make
pip
python-build
Expand All @@ -154,9 +153,21 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}

- name: Install uv
uses: astral-sh/[email protected]

- name: Install dvc
run: |
uv venv
source .venv/bin/activate
uv pip install dvc
uv pip list

# Pull baseline image data from dvc remote (DAGsHub)
- name: Pull baseline image data from dvc remote
run: dvc pull --no-run-cache --verbose && ls -lhR pygmt/tests/baseline/
run: |
source .venv/bin/activate
uv run dvc pull --no-run-cache --verbose && ls -lhR pygmt/tests/baseline/
Comment on lines +159 to +170
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can combine the "Install dvc" and "Pull baseline image data from dvc remote" steps into one step "Setup DVC and pull baseline image data from dvc remote", so we don't have to source .venv/bin/activate twice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just keep this as is, since I'm assuming this will be a temporary workaround until conda-forge's dvc supports Python 3.13. We might want to revert the changes here after a few months, so best to have two separate steps.


# Install the package that we want to test
- name: Install the package
Expand Down
Loading