Figure.meca: Refactor to improve the processing of the input data #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
seisman
force-pushed
the
refactor/meca_in
branch
from
0089020 to
bd0ccfa
Compare
michaelgrund
approved these changes
Mar 5, 2025
michaelgrund
added
final review call
seisman
removed
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract two private functions
_preprocess_specand_set_offsetto simplify the mainFigure.mecafunction, so that theFigure.coupefunction (#3817) can be much simplified if we decide to have a separateFigure.coupefunction.The main logic of codes is close to the original ones, but the codes are much simplified. The most significant difference is that, previously, we converted
specto a pandas.DataFrame object if possible, but now we convertspecto a dict instead. A dict is very similar to apandas.DataFrameobject, but thepd.DataFrame->dict conversion is more efficient than the dict->pd.DataFrame conversion.