Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset "GSHHG Earth distance to shoreline": Update docs and add coastlines to images #126

Merged

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Dec 23, 2024

Please see comment GenericMappingTools/pygmt#3706 (comment) for context.

Update the documentation for the remote dataset "GSHHG Earth distance to shoreline":

  • Mention distance unit is km
  • Mention distances have both negative and positive values. Positive means land to coastline and negative means ocean to coastline.
  • Add the coastline to the image to make the it more readable.

Preview: https://remote-datasets--126.org.readthedocs.build/en/126/earth-dist.html

scripts/GMT_earth_maps.sh Outdated Show resolved Hide resolved
@seisman seisman requested a review from Esteban82 December 24, 2024 10:07
@seisman
Copy link
Member

seisman commented Dec 24, 2024

Looks good to me and ping @Esteban82 for review.

@Esteban82
Copy link
Member

Esteban82 commented Dec 24, 2024

It looks fine @yvonnefroehlich. Is still a WIP? If not, please remove it from the title.

@yvonnefroehlich yvonnefroehlich changed the title WIP / POC: Udate the docs for dataset "GSHHG Earth distance to shoreline" Udate the docs for dataset "GSHHG Earth distance to shoreline" Dec 24, 2024
@yvonnefroehlich yvonnefroehlich changed the title Udate the docs for dataset "GSHHG Earth distance to shoreline" Dataset "GSHHG Earth distance to shoreline": Update docs and add coastlines to images Dec 24, 2024
@seisman seisman merged commit b447dc1 into GenericMappingTools:main Dec 24, 2024
3 checks passed
@yvonnefroehlich
Copy link
Member Author

It looks fine @yvonnefroehlich. Is still a WIP? If not, please remove it from the title.

This PR should be finished. I updated the title.

@yvonnefroehlich yvonnefroehlich deleted the update-doc-earth-dist branch December 24, 2024 13:33
@yvonnefroehlich yvonnefroehlich self-assigned this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants