Upgrade hamcrest from 1.3 to 3.0 #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaime
reviewed
Aug 19, 2024
| public void appendTo(StringBuffer buffer) { | ||
| matcher.describeTo(new StringDescription(buffer)); | ||
| } | ||
| }); | ||
| return null; |
There was a problem hiding this comment.
This bit has me confused.. if we return null, is the object being built in the previous step even used?
There was a problem hiding this comment.
The old and new code both return null here. I think that easymock is adding the matcher to a static field so the return value isn't very important. I personally find mockito to be clearer and easier to use even though geoserver uses easymock more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test dependency upgrade.
This PR adds the hamcrest 3.0 dependency to the root pom.xml and removes all hamcrest-core, hamcrest-library and hamcrest-integration dependencies. The version is set to 3.0 for hamcrest-core and hamcrest-library in case there is another transitive dependency on it (these are empty jar files). hamcrest-integration has no version beyond 1.3.
Some code changes were required for deprecated or removed API.