Upgrade eigen to 3.4.0 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vissarion
approved these changes
Oct 11, 2021
| @@ -137,15 +138,15 @@ void call_test_uniform_generator(){ | |||
| exact_vol = exact_zonotope_vol<NT>(P); | |||
| test_volume_hpoly(P, | |||
| 0, | |||
| 5.7603e+20, | |||
There was a problem hiding this comment.
any idea of what have changed in Eigen and there are those changes in test results ?
There was a problem hiding this comment.
not sure, my guess is that these are due to numerical instability for skinny objects.
There was a problem hiding this comment.
but the process is deterministic (in the tests), they probably changed some algorithms in eigen that volesti uses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this, the issue #105 (replacing Eigen pointers with iterators) can be worked upon by anyone. IMO, it can be given a label of
hacktoberfest.