Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [FEAT] Add CirkwiParser to retrieve Treks and Touristic Contents (refs #3947) #3968

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Feb 29, 2024

Description

Related Issue

#3947

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@Chatewgne Chatewgne force-pushed the feat_cirkwi_parser branch 2 times, most recently from 2f125da to 5173b63 Compare February 29, 2024 16:32
@Chatewgne Chatewgne changed the title ✨ [FEAT] Add to retrieve Treks and Touristic Contents (refs #3947) ✨ [FEAT] Add CirkwiParser to retrieve Treks and Touristic Contents (refs #3947) Feb 29, 2024
Copy link

cypress bot commented Feb 29, 2024

Geotrek-admin    Run #10339

Run Properties:  status check passed Passed #10339  •  git commit d8f2ea4702 ℹ️: Merge 46d0c352bd170765cda73cca839c9672c5256cbb into e6096d7e1012bc16c9ce1e9542b4...
Project Geotrek-admin
Branch Review refs/pull/3968/merge
Run status status check passed Passed #10339
Run duration 02m 02s
Commit git commit d8f2ea4702 ℹ️: Merge 46d0c352bd170765cda73cca839c9672c5256cbb into e6096d7e1012bc16c9ce1e9542b4...
Committer Célia
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 90.21739% with 18 lines in your changes missing coverage. Please review.

Project coverage is 98.38%. Comparing base (b89ae96) to head (cc0ec21).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
geotrek/cirkwi/parsers.py 90.21% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3968      +/-   ##
==========================================
- Coverage   98.45%   98.38%   -0.08%     
==========================================
  Files         267      268       +1     
  Lines       21104    21288     +184     
==========================================
+ Hits        20778    20944     +166     
- Misses        326      344      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chatewgne Chatewgne force-pushed the feat_cirkwi_parser branch 10 times, most recently from 6add793 to 809dfb9 Compare March 4, 2024 16:55
@Chatewgne Chatewgne force-pushed the feat_cirkwi_parser branch 8 times, most recently from a797a24 to cc0ec21 Compare November 15, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants