Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] Fix SchemaRandonneeParser url update (refs #4022) #4369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justinefricou
Copy link
Contributor

@justinefricou justinefricou commented Nov 15, 2024

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@justinefricou justinefricou changed the title Fix schema randonnee parser url parsing 🐛 [BUG] Fix schema randonnee parser url parsing Nov 15, 2024
@justinefricou justinefricou changed the title 🐛 [BUG] Fix schema randonnee parser url parsing 🐛 [BUG] Fix SchemaRandonneeParser url update Nov 15, 2024
Copy link

cypress bot commented Nov 15, 2024

Geotrek-admin    Run #10345

Run Properties:  status check passed Passed #10345  •  git commit d4618665ed ℹ️: Merge 8fd0b0130c7b6c14303965250c7482b0bbbc21bc into e6096d7e1012bc16c9ce1e9542b4...
Project Geotrek-admin
Branch Review refs/pull/4369/merge
Run status status check passed Passed #10345
Run duration 02m 06s
Commit git commit d4618665ed ℹ️: Merge 8fd0b0130c7b6c14303965250c7482b0bbbc21bc into e6096d7e1012bc16c9ce1e9542b4...
Committer Justine Fricou
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (b89ae96) to head (8fd0b01).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4369   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         267      267           
  Lines       21104    21114   +10     
=======================================
+ Hits        20778    20788   +10     
  Misses        326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinefricou justinefricou force-pushed the fix_SchemaRandonneeParser_url_parsing branch 3 times, most recently from cf0c0de to 7895e4e Compare November 15, 2024 15:07
@justinefricou justinefricou marked this pull request as ready for review November 15, 2024 15:20
- fix url being duplicated in description after new import if description is null or was not updated
- add static method to find url in description to help other parsers find it
@justinefricou justinefricou force-pushed the fix_SchemaRandonneeParser_url_parsing branch from 7895e4e to 8fd0b01 Compare November 18, 2024 09:25
@justinefricou justinefricou changed the title 🐛 [BUG] Fix SchemaRandonneeParser url update 🐛 [BUG] Fix SchemaRandonneeParser url update (refs #4022) Nov 18, 2024
@babastienne babastienne requested a review from a team November 18, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant