Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💫 [IMPR] Remove overriding of SchemaRandonneeParser's filetype_name (refs #4022) #4375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

💫 [IMPR] Remove overriding of SchemaRandonneeParser's filetype_name (refs #4022) #4375

wants to merge 1 commit into from

Conversation

justinefricou
Copy link
Contributor

@justinefricou justinefricou commented Nov 18, 2024 •
edited
Loading

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@justinefricou justinefricou force-pushed the mod_SchemaRandonneeParser_filetype_name branch from 9f3c071 to 2495356 Compare November 18, 2024 14:42
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (eb9cd20) to head (2495356).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4375      +/-   ##
==========================================
- Coverage   98.45%   98.45%   -0.01%     
==========================================
  Files         267      267              
  Lines       21104    21103       -1     
==========================================
- Hits        20778    20777       -1     
  Misses        326      326

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress Cypress
Copy link

cypress bot commented Nov 18, 2024 •
edited
Loading

Geotrek-admin    Run #10352

Run Properties:  status check passed Passed #10352  •  git commit ffd6575ce0 ℹ️: Merge 249535625887169d0f6a7bfe9fa228d536aae4f8 into eb9cd203c77a8780817850576560...
Project Geotrek-admin
Branch Review refs/pull/4375/merge
Run status status check passed Passed #10352
Run duration 02m 10s
Commit git commit ffd6575ce0 ℹ️: Merge 249535625887169d0f6a7bfe9fa228d536aae4f8 into eb9cd203c77a8780817850576560...
Committer Justine Fricou
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@justinefricou justinefricou marked this pull request as ready for review November 18, 2024 14:57
@justinefricou justinefricou requested a review from a team November 18, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
💫 Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@justinefricou