Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deoplying FE-BE as a single command using mup hooks #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shailee-m
Copy link
Member

No description provided.

@shailee-m shailee-m requested a review from brylie March 15, 2021 15:55
deploy-all.sh Outdated
cd wellbeing-client/frontend && yarn && cd ../../

echo "export PATH=$PATH:$(npm get prefix)/bin" >> ~/.bashrc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to modify .bashrc for this deployment? That seems like an unnecessary side-effect. Can't we use a session variable in the shell script?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not able to find local dependencies

@shailee-m
Copy link
Member Author

shailee-m commented Mar 15, 2021

@brylie if you test the clone-sources.sh file, try it with git clone https://github.com/GeriLife/wellbeing-client.git --branch develop as in master we still do not have any code

@brylie
Copy link
Member

brylie commented Mar 16, 2021

Looks good. Try to clean up any duplicate code, so that each script is distinct.

I'm going to re-evaluate how we are deploying these two Docker projects. E.g. we might just be able to use Dokku or Docker Compose. We will also probably need to publish these Docker images to Docker Hub.

@shailee-m
Copy link
Member Author

Looks good. Try to clean up any duplicate code, so that each script is distinct.

I'm going to re-evaluate how we are deploying these two Docker projects. E.g. we might just be able to use Dokku or Docker Compose. We will also probably need to publish these Docker images to Docker Hub.

Dokku seems to be easier we can look into it.

Also, the meteor official document mentions some prebuild images we can use that too. This one seems to be maintained https://github.com/tozd/docker-meteor

@brylie
Copy link
Member

brylie commented Mar 18, 2021

OK, thanks Shailee. Would you be able to look into a full stack deployment approach, such as Dokku? Each part of the stack can be deployed independently, of course. In the end though, we want to be able to easily deploy all end-to-end components on the same server.

@shailee-m
Copy link
Member Author

@brylie We can set up this folder directly using dokku or we can set up the client and the meteor folder separately on Hetzner dokku and add a common shell script for starting the instances on Hetzener.

I am trying the second approach this way we have the freedom of individually handling updates and deployments. However, It seems that the admin has to map ssh keys to each server for them to be used for remote login. Can you check if you have an access keys menu for our test server in hetzner?

@brylie
Copy link
Member

brylie commented Mar 23, 2021

@shailee-m feel free to spin up another server. When starting the server, it lets you choose an SSH key. Be sure to destroy the servers you are no longer using.

If creating a new server doesn't resolve the issue, let me know. I can take a closer look at the SSH keys, if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants