Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various networking limitations/issues before release. #51

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix various networking limitations/issues before release. #51

wants to merge 3 commits into from

Conversation

ewlsh
Copy link
Member

@ewlsh ewlsh commented Aug 25, 2020 •
edited
Loading

  • Authentication should avoid unnecessary network calls.
  • Strict timeouts should be enforced on all user facing APIs
  • Listeners shouldn't gradually drain resources if Google Cloud outages occurs

TODOs

  • Test changes locally and in development
  • Ensure timeouts don't break iPad functionality
  • Enforce corresponding timeouts in web apps

@ewlsh ewlsh requested a review from ashneeldas2 August 25, 2020 18:44
@ewlsh
Copy link
Member Author

ewlsh commented Aug 25, 2020

@ashneeldas2 @henryz2000 see gygb-client-web/#58 for the corresponding issue on the frontend.

@ewlsh
Listeners should handle firestore outages better.
ecea6aa 
If Firestore has an outage we currently run the risk of
exhausting resources by continuously attempting to
reconnect. Instead, we'll try to reconnect a few times
which should handle the case where a network error on our
side broke the connection.

Additional Changes
- Formatter cleaned up the file.
- Make cached access synchronous.
@ewlsh
Enforce timeouts for requests and responses.
956c64e 
By default Node.js and express timeout after 2 minutes,
this is too long for our use case and Heroku, the current
host, gives an H12 (timeout error) after only 30 seconds.

Instead we now set the following timeouts:
- Database calls: 15 seconds
- API requests: 10 seconds
- API responses: 10 seconds
@ewlsh
Avoid network authentication calls if unnecessary.
c0cd36c 
If a token is invalid locally, it will also be invalid on
a network call. Network calls only detect if a valid
token has since been revoked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashneeldas2 ashneeldas2 Awaiting requested review from ashneeldas2

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ewlsh