Pinned changed event #174
Merged
Pinned changed event #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesyncim
reviewed
Jul 28, 2023
| // pinned_sessions contains the list of sessions that are pinned | ||
| // in the call. The order of the sessions in the list is the order | ||
| // in which they are pinned (descending order of priority). | ||
| repeated string pinned_sessions = 1; |
There was a problem hiding this comment.
Should we call it pinned_user_ids?
remote rpc calls are never session aware so this term is confusing
There was a problem hiding this comment.
this is not an rpc between coordinator and SFU, this is the event from SFU to clients
There was a problem hiding this comment.
and we need to specify the session_id because a user can be connected multiple times/have multiple tracks
thesyncim
approved these changes
Jul 28, 2023
oliverlaz
added a commit
to GetStream/stream-video-js
that referenced
this pull request
Aug 7, 2023
Adds support for Server-Side participant pinning. Reference: GetStream/chat#5239, GetStream/protocol#174 Specs: https://www.notion.so/stream-wiki/Video-Pinning-2b348a962da742389f734b7fd9b1cf46 ## Breaking changes This PR brings a small breaking change in the participant pinning API. Previously, we used to have `call.setParticipantPinnedAt` API which is now replaced with `call.pin(sessionId)` and `call.unpin(sessionId)` APIs. Additionally, the `participant.pinnedAt` property has been replaced with a new `pin` structure of this shape: ``` const participant = { ..., pin: { isLocal: boolean, // set to `true` when this participant is server-side pinned pinnedAt: number, // a timestamp, shows when "pinning" happened } } ``` --------- Co-authored-by: Khushal Agarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an SFU event to notify when the list of pinned session has changed, the same information is also returned when joining the call as part of the JoinResponse