Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageTheme.quotedTextStyle has no effect #5307

Closed
zeroarst opened this issue Jul 1, 2024 · 5 comments · Fixed by #5310
Closed

MessageTheme.quotedTextStyle has no effect #5307

zeroarst opened this issue Jul 1, 2024 · 5 comments · Fixed by #5310
Assignees
Labels
bug Something isn't working PR Created

Comments

@zeroarst
Copy link

zeroarst commented Jul 1, 2024

Describe the bug
A clear and concise description of what the bug is.

SDK version

  • 6.4.0

To Reproduce
Set the quoteTextStyle as below:

 ChatTheme(
        ownMessageTheme = MessageTheme.defaultOwnTheme().let { theme ->
            theme.copy(
                backgroundColor = Color(0xff343F93),
                textStyle = theme.textStyle.copy(
                    color = Color.Red
                ),
                quotedBackgroundColor = Color.White,
                quotedTextStyle = theme.quotedTextStyle.copy(
                    color = Color.Green // This has no effect.
                ),
            )
        },
    ) {
        // Stream components.
    }
)

Does not apply the color to quoted text. With above example, the quoted text should show green text color.
image

I look at the source code, I cannot find quotedTextStyle is used anywhere. Checked QuotedMessage, QuotedMessageContent, QuotedMessageText.

image

Expected behavior
Quoted text color is changed.

Device:

  • Vendor and model: Pixel 3a
  • Android version: 14
@zeroarst zeroarst added the bug Something isn't working label Jul 1, 2024
@aleksandar-apostolov
Copy link
Collaborator

Hey @zeroarst thanks for the report, indeed its has no effect. We will fix this in the next release.

@zeroarst
Copy link
Author

I tried the latest version (6.4.4) and the issue still persists. ChatTheme.ownMessageTheme.quotedTextStyle is correctly passed to the Text compose, but the color seems to be ovewritten by styledText: AnnotatedString color. As you can see from below's screenhot.
style has green color;
styledText has a red color SpanStyle;
Stream Chat Bug - Invalid Quoted Message Color

@kanat
Copy link
Collaborator

kanat commented Aug 26, 2024

Hey @zeroarst,

Thank you letting us know.
We'll address this issue asap.

@kanat
Copy link
Collaborator

kanat commented Aug 26, 2024

Hi @zeroarst,

This PR should fix the problem.
It will be available with the next upcoming release.

@kanat kanat self-assigned this Aug 26, 2024
@kanat
Copy link
Collaborator

kanat commented Sep 5, 2024

Fixed in v6.5.0

@kanat kanat closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR Created
Projects
None yet
3 participants