Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBE-5700] Quoted text style has no effect #5373

Merged
merged 2 commits into from
Aug 27, 2024
Merged

[PBE-5700] Quoted text style has no effect #5373

merged 2 commits into from
Aug 27, 2024

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Aug 26, 2024 •
edited
Loading

🎯 Goal

Closes:

Related PR:

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat requested a review from a team as a code owner August 26, 2024 19:32
@kanat kanat mentioned this pull request Aug 26, 2024
Closed
skydoves
skydoves approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@JcMinarro JcMinarro enabled auto-merge (rebase) August 27, 2024 10:17
@JcMinarro JcMinarro merged commit 0f11547 into develop Aug 27, 2024
7 checks passed
@JcMinarro JcMinarro deleted the fix/quoted-text-style branch August 27, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kanat @JcMinarro @skydoves