Refactor static access #4729
Merged
Refactor static access #4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JcMinarro
requested review from
kanat,
leandroBorgesFerreira,
MarinTolic and
a team
JcMinarro
force-pushed
the
refactor-static-access
branch
2 times, most recently
from
5ffa2f5
to
7c7c962
Compare
JcMinarro
added
the
merge before v6 release
MarinTolic
suggested changes
Mar 15, 2023
JcMinarro
force-pushed
the
refactor-static-access
branch
3 times, most recently
from
917bdd1
to
21f5407
Compare
JcMinarro
force-pushed
the
refactor-static-access
branch
from
21f5407
to
b6371c4
Compare
MarinTolic
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
☑️Reviewer Checklist
- UI Components sample runs & works
- Compose sample runs & works
- UI Changes correct (before & after images)
- Bugs validated (bugfixes)
- New feature tested and works
- Release notes and docs clearly describe changes
- All code we touched has new or updated KDocs
...ate/src/main/java/io/getstream/chat/android/state/plugin/factory/StreamStatePluginFactory.kt
Show resolved
Hide resolved
leandroBorgesFerreira
approved these changes
Mar 17, 2023
kanat
reviewed
Mar 17, 2023
...am-chat-android-state/src/main/java/io/getstream/chat/android/state/extensions/ChatClient.kt
Show resolved
Hide resolved
kanat
reviewed
Mar 17, 2023
| @@ -205,7 +204,7 @@ private fun <T> ChatClient.getStateOrNull( | |||
| */ | |||
| @CheckResult | |||
| public fun ChatClient.setMessageForReply(cid: String, message: Message?): Call<Unit> { | |||
| return CoroutineCall(state.scope) { | |||
| return CoroutineCall(inheritScope { SupervisorJob(it) }) { | |||
There was a problem hiding this comment.
Hey @JcMinarro
Would you mind replacing SupervisorJob with Job?
I assume we don't need to supervise anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
We were using some classes with the old approach to have it as a singleton and obtain it by
get()method returning an exception if it wasn't initialized yet.This old way is not needed anymore as we have our own "DepencencyResolver" to find dependencies from plugins that were added to the SDK.
Fix: #4717
🛠 Implementation details
Configure
StatePluginto provide needed dependencies.ChatClient::resolveDependency()method has been update to provide better error on the case plugins wasn't initialized properly☑️Contributor Checklist
General
developbranchCode & documentation
☑️Reviewer Checklist
🎉 GIF