Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i70_&_i80] Add attachment verifier #4852

Merged
merged 3 commits into from
Jul 4, 2023
Merged

[i70_&_i80] Add attachment verifier #4852

merged 3 commits into from
Jul 4, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Jun 23, 2023 •
edited
Loading

🎯 Goal

Relates to:

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat added the v6-beta An issue for targeting v6-beta label Jun 23, 2023
@kanat kanat requested a review from JcMinarro June 23, 2023 21:45
@kanat kanat assigned skydoves and unassigned skydoves Jun 23, 2023
@kanat kanat requested a review from skydoves June 23, 2023 21:45
@kanat kanat marked this pull request as ready for review June 23, 2023 21:45
@kanat kanat requested a review from a team as a code owner June 23, 2023 21:45
@kanat kanat changed the title Add attachment verifier [i70&i80] Add attachment verifier Jun 23, 2023
@kanat kanat changed the title [i70&i80] Add attachment verifier [i70_&_i80] Add attachment verifier Jun 23, 2023
@kanat kanat added the core label Jun 23, 2023
@JcMinarro JcMinarro enabled auto-merge (rebase) July 4, 2023 09:36
@JcMinarro JcMinarro merged commit 5c8fd5a into develop Jul 4, 2023
7 checks passed
@JcMinarro JcMinarro deleted the issue/attach-metadata branch July 4, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

@skydoves skydoves Awaiting requested review from skydoves

Assignees
No one assigned
Labels
core v6-beta An issue for targeting v6-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kanat @JcMinarro @skydoves