Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i88] Make message text style customizable on Compose #4855

Merged
merged 3 commits into from
Jul 3, 2023
Merged

[i88] Make message text style customizable on Compose #4855

merged 3 commits into from
Jul 3, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Jun 29, 2023 •
edited
Loading

🎯 Goal

Closes: https://github.com/GetStream/android-internal-board/issues/88

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the v5 branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat marked this pull request as ready for review June 29, 2023 19:42
@kanat kanat requested a review from a team as a code owner June 29, 2023 19:42
@kanat kanat added compose Jetpack Compose v5 enhancement New feature or request labels Jun 29, 2023
JcMinarro
JcMinarro approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@JcMinarro JcMinarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JcMinarro JcMinarro enabled auto-merge (rebase) July 3, 2023 10:46
@JcMinarro JcMinarro merged commit 26fc7fe into v5 Jul 3, 2023
5 checks passed
@JcMinarro JcMinarro deleted the improvement/msg-theme branch July 3, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees
No one assigned
Labels
compose Jetpack Compose enhancement New feature or request v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanat @JcMinarro