Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4786] add migration guide for package restructure in ui-common #4882

Merged
merged 3 commits into from
Jul 24, 2023
Merged

[4786] add migration guide for package restructure in ui-common #4882

merged 3 commits into from
Jul 24, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Jul 19, 2023 •
edited
Loading

🎯 Goal

Relates to: #4786

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat marked this pull request as ready for review July 19, 2023 23:02
@kanat kanat requested a review from a team as a code owner July 19, 2023 23:02
@kanat kanat linked an issue Jul 19, 2023 that may be closed by this pull request
Migration of StyleTransformer, SupportedReactions and TransformStyle #4786
Closed
@kanat kanat changed the title Guides/package structure UI common [4786] add migration guide for package restructure in ui-common Jul 19, 2023
@kanat kanat requested a review from JcMinarro July 19, 2023 23:04
skydoves
skydoves approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@kanat kanat added the v6-beta An issue for targeting v6-beta label Jul 22, 2023
@JcMinarro JcMinarro enabled auto-merge (rebase) July 24, 2023 08:26
@JcMinarro JcMinarro merged commit 91bf095 into develop Jul 24, 2023
7 checks passed
@JcMinarro JcMinarro deleted the guides/package-structure-ui-common branch July 24, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
v6-beta An issue for targeting v6-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration of StyleTransformer, SupportedReactions and TransformStyle
3 participants
@kanat @JcMinarro @skydoves