Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i74] Enhance audio recording ui customization #4906

Merged
merged 4 commits into from
Jul 31, 2023
Merged

[i74] Enhance audio recording ui customization #4906

merged 4 commits into from
Jul 31, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Jul 28, 2023 •
edited
Loading

🎯 Goal

Relates to #4828

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat marked this pull request as ready for review July 28, 2023 05:33
@kanat kanat requested a review from a team as a code owner July 28, 2023 05:33
@kanat kanat requested a review from JcMinarro July 28, 2023 05:33
@kanat kanat changed the title Enhance audio recording ui customization [i74] Enhance audio recording ui customization Jul 28, 2023
@kanat kanat added the v6-beta An issue for targeting v6-beta label Jul 28, 2023
@JcMinarro JcMinarro force-pushed the task/audio-ui-customization branch from 153ddb3 to ee22d39 Compare July 31, 2023 10:29
@JcMinarro JcMinarro enabled auto-merge (rebase) July 31, 2023 10:48
@JcMinarro JcMinarro merged commit c69799f into develop Jul 31, 2023
7 checks passed
@JcMinarro JcMinarro deleted the task/audio-ui-customization branch July 31, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees
No one assigned
Labels
v6-beta An issue for targeting v6-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanat @JcMinarro