Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i107] expose notification color #4921

Merged
merged 2 commits into from
Aug 16, 2023
Merged

[i107] expose notification color #4921

merged 2 commits into from
Aug 16, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Aug 14, 2023

🎯 Goal

Closes: https://github.com/GetStream/android-internal-board/issues/107

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat added the v6-beta An issue for targeting v6-beta label Aug 14, 2023
@kanat kanat requested a review from JcMinarro August 14, 2023 20:19
@kanat kanat marked this pull request as ready for review August 14, 2023 20:19
@kanat kanat requested a review from a team as a code owner August 14, 2023 20:19
@kanat kanat added the enhancement New feature or request label Aug 14, 2023
@kanat kanat merged commit cc2d94d into develop Aug 16, 2023
7 checks passed
@kanat kanat deleted the v6/notification-color branch August 16, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro Awaiting requested review from JcMinarro

Assignees
No one assigned
Labels
enhancement New feature or request v6-beta An issue for targeting v6-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kanat