Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i231] Old messages are read by newly added member #5138

Merged
merged 3 commits into from
Jan 9, 2024
Merged

[i231] Old messages are read by newly added member #5138

merged 3 commits into from
Jan 9, 2024

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Jan 4, 2024

🎯 Goal

Closes:

Related to:

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat marked this pull request as ready for review January 4, 2024 23:23
@kanat kanat requested a review from a team as a code owner January 4, 2024 23:23
@kanat kanat added bug Something isn't working ui-components v5 labels Jan 4, 2024
skydoves
skydoves approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@JcMinarro JcMinarro merged commit c9a06d0 into v5 Jan 9, 2024
5 checks passed
@JcMinarro JcMinarro deleted the bugfix/message-read branch January 9, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNovak DanielNovak DanielNovak approved these changes

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ui-components v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kanat @DanielNovak @skydoves @JcMinarro