Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(github) fix vale step in GitHub workflow #5147

Merged
merged 1 commit into from
Jan 15, 2024
Merged

(github) fix vale step in GitHub workflow #5147

merged 1 commit into from
Jan 15, 2024

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Jan 13, 2024

🎯 Goal

Fixes GH workflow.

Related change in iOS:

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat marked this pull request as ready for review January 13, 2024 00:37
@kanat kanat requested a review from a team as a code owner January 13, 2024 00:37
@kanat kanat added v6 and removed v6 labels Jan 13, 2024
@JcMinarro JcMinarro changed the base branch from main to develop January 15, 2024 09:44
@JcMinarro JcMinarro merged commit 687ba93 into develop Jan 15, 2024
7 checks passed
@JcMinarro JcMinarro deleted the vale-lint branch January 15, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees
No one assigned
Labels
v6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanat @JcMinarro