-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show label when a message was edited #5200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DB Entities have been updated. Do we need to upgrade DB Version?
|
JcMinarro
force-pushed
the
feature/edited-message-label
branch
from
March 10, 2024 09:32
fe7fd6b
to
9b9bba6
Compare
JcMinarro
force-pushed
the
feature/edited-message-label
branch
from
March 11, 2024 12:42
9b9bba6
to
16c9069
Compare
JcMinarro
force-pushed
the
feature/edited-message-label
branch
from
March 12, 2024 17:51
16c9069
to
d615ada
Compare
kanat
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@JcMinarro would you mind adding a link to the ticket? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Show label when a message was edited
Complete: https://github.com/GetStream/android-internal-board/issues/260
🛠 Implementation details
The
Message
entity has a new property notifying us a text message was edited.The
Fotenote
view has been updated to reflect this info. If it is clicked, expanded info is shown.🎨 UI Changes
Add relevant screenshots
Add relevant videos
🎉 GIF