Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show label when a message was edited #5200

Merged
merged 10 commits into from
Mar 14, 2024
Merged

Conversation

JcMinarro
Copy link
Member

@JcMinarro JcMinarro commented Mar 10, 2024

🎯 Goal

Show label when a message was edited
Complete: https://github.com/GetStream/android-internal-board/issues/260

🛠 Implementation details

The Message entity has a new property notifying us a text message was edited.
The Fotenote view has been updated to reflect this info. If it is clicked, expanded info is shown.

🎨 UI Changes

Add relevant screenshots

Before After
img img

Add relevant videos

Before After

🎉 GIF

@JcMinarro JcMinarro requested a review from a team as a code owner March 10, 2024 09:11
Copy link
Contributor

DB Entities have been updated. Do we need to upgrade DB Version?
Modified Entities :

stream-chat-android-offline/src/main/java/io/getstream/chat/android/offline/repository/domain/message/internal/MessageEntity.kt
stream-chat-android-offline/src/main/java/io/getstream/chat/android/offline/repository/domain/message/internal/ReplyMessageEntity.kt

@JcMinarro JcMinarro force-pushed the feature/edited-message-label branch from fe7fd6b to 9b9bba6 Compare March 10, 2024 09:32
@JcMinarro JcMinarro force-pushed the feature/edited-message-label branch from 9b9bba6 to 16c9069 Compare March 11, 2024 12:42
Copy link
Collaborator

@kanat kanat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanat
Copy link
Collaborator

kanat commented Mar 14, 2024

@JcMinarro would you mind adding a link to the ticket? :)

@JcMinarro JcMinarro merged commit 2ff3ef8 into develop Mar 14, 2024
8 checks passed
@JcMinarro JcMinarro deleted the feature/edited-message-label branch March 14, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants