-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i269] Add theming for reaction and message options in ChatTheme #5226
Merged
aleksandar-apostolov
merged 10 commits into
develop
from
feature/control-message-options-locally
Jun 18, 2024
Merged
[i269] Add theming for reaction and message options in ChatTheme #5226
aleksandar-apostolov
merged 10 commits into
develop
from
feature/control-message-options-locally
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liviu-timar
force-pushed
the
feature/control-message-options-locally
branch
3 times, most recently
from
April 3, 2024 14:27
62c5243
to
7810267
Compare
liviu-timar
commented
Apr 3, 2024
...o/getstream/chat/android/compose/ui/components/messageoptions/MessageOptionItemVisibility.kt
Show resolved
Hide resolved
liviu-timar
commented
Apr 3, 2024
...o/getstream/chat/android/compose/ui/components/messageoptions/MessageOptionItemVisibility.kt
Show resolved
Hide resolved
liviu-timar
commented
Apr 3, 2024
...o/getstream/chat/android/compose/ui/components/messageoptions/MessageOptionItemVisibility.kt
Show resolved
Hide resolved
liviu-timar
commented
Apr 3, 2024
...o/getstream/chat/android/compose/ui/components/messageoptions/MessageOptionItemVisibility.kt
Show resolved
Hide resolved
liviu-timar
commented
Apr 3, 2024
...o/getstream/chat/android/compose/ui/components/messageoptions/MessageOptionItemVisibility.kt
Show resolved
Hide resolved
liviu-timar
force-pushed
the
feature/control-message-options-locally
branch
from
April 3, 2024 15:01
18c8532
to
a229096
Compare
liviu-timar
commented
Apr 3, 2024
...c/main/java/io/getstream/chat/android/compose/ui/components/messageoptions/MessageOptions.kt
Outdated
Show resolved
Hide resolved
kanat
reviewed
Apr 3, 2024
...c/main/java/io/getstream/chat/android/compose/ui/components/messageoptions/MessageOptions.kt
Outdated
Show resolved
Hide resolved
liviu-timar
force-pushed
the
feature/control-message-options-locally
branch
from
April 5, 2024 10:33
04ea09a
to
e01d636
Compare
liviu-timar
changed the title
[i269] Allow control of message options visibility via ChatTheme
[i269] Add theming for reaction and message options in ChatTheme
Apr 5, 2024
liviu-timar
force-pushed
the
feature/control-message-options-locally
branch
from
April 5, 2024 12:54
6b70016
to
b18ba92
Compare
aleksandar-apostolov
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Add new
theme
properties toChatTheme
that control visibility of reaction and message option lists in the selected message menu.Closes:
🛠 Implementation details
ChatTheme
properties:reactionOptionsTheme
andmessageOptionsTheme
.SelectedMessageMenu.headerContent
and indefaultMessageOptionsState()
to control option visibility.🧪 Testing
Pass custom values to the new
ChatTheme
parameters in the sample app and check if reaction & message options are visible/hidden when long tapping on a message.☑️Contributor Checklist
General
develop
branchCode & documentation
☑️Reviewer Checklist