Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i269] Add theming for reaction and message options in ChatTheme #5226

Merged
merged 10 commits into from
Jun 18, 2024

Conversation

liviu-timar
Copy link
Member

@liviu-timar liviu-timar commented Apr 2, 2024

🎯 Goal

Add new theme properties to ChatTheme that control visibility of reaction and message option lists in the selected message menu.

Closes:

🛠 Implementation details

  • Added two new ChatTheme properties: reactionOptionsTheme and messageOptionsTheme.
  • Used these new properties in SelectedMessageMenu.headerContent and in defaultMessageOptionsState() to control option visibility.
  • Documented new features.

🧪 Testing

Pass custom values to the new ChatTheme parameters in the sample app and check if reaction & message options are visible/hidden when long tapping on a message.

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

@liviu-timar liviu-timar force-pushed the feature/control-message-options-locally branch 3 times, most recently from 62c5243 to 7810267 Compare April 3, 2024 14:27
@liviu-timar liviu-timar force-pushed the feature/control-message-options-locally branch from 18c8532 to a229096 Compare April 3, 2024 15:01
@liviu-timar liviu-timar marked this pull request as ready for review April 3, 2024 15:01
@liviu-timar liviu-timar requested a review from a team as a code owner April 3, 2024 15:01
@kanat kanat added enhancement New feature or request compose Jetpack Compose v6 labels Apr 4, 2024
@liviu-timar liviu-timar force-pushed the feature/control-message-options-locally branch from 04ea09a to e01d636 Compare April 5, 2024 10:33
@liviu-timar liviu-timar changed the title [i269] Allow control of message options visibility via ChatTheme [i269] Add theming for reaction and message options in ChatTheme Apr 5, 2024
@liviu-timar liviu-timar force-pushed the feature/control-message-options-locally branch from 6b70016 to b18ba92 Compare April 5, 2024 12:54
@aleksandar-apostolov aleksandar-apostolov enabled auto-merge (squash) June 18, 2024 11:03
@aleksandar-apostolov aleksandar-apostolov merged commit dd721be into develop Jun 18, 2024
7 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the feature/control-message-options-locally branch June 18, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compose Jetpack Compose enhancement New feature or request v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants