Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBE-2783] Infinite progress bar on ChannelList screen #5259

Merged
merged 3 commits into from
May 14, 2024
Merged

[PBE-2783] Infinite progress bar on ChannelList screen #5259

merged 3 commits into from
May 14, 2024

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented May 14, 2024

🎯 Goal

Closes:

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat requested a review from a team as a code owner May 14, 2024 02:05
@kanat kanat added bug Something isn't working compose Jetpack Compose v6 labels May 14, 2024
@JcMinarro JcMinarro enabled auto-merge (rebase) May 14, 2024 09:21
@JcMinarro JcMinarro merged commit 958a8f9 into develop May 14, 2024
7 checks passed
@JcMinarro JcMinarro deleted the bugfix/infinite-loader branch May 14, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees
No one assigned
Labels
bug Something isn't working compose Jetpack Compose v6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanat @JcMinarro