Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the R8 issue for the previewdata module #5365

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Fix the R8 issue for the previewdata module #5365

merged 1 commit into from
Aug 21, 2024

Conversation

skydoves
Copy link
Member

@skydoves skydoves commented Aug 21, 2024 •
edited
Loading

🎯 Goal

Fix the R8 issue for the previewdata module. ((#5359)

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@skydoves skydoves self-assigned this Aug 21, 2024
@skydoves skydoves marked this pull request as ready for review August 21, 2024 01:49
@skydoves skydoves requested a review from a team as a code owner August 21, 2024 01:49
@skydoves skydoves changed the title Fix the R8 issue for the previewdata module (#5359) Fix the R8 issue for the previewdata module Aug 21, 2024
@JcMinarro JcMinarro enabled auto-merge (rebase) August 21, 2024 17:30
@JcMinarro JcMinarro merged commit 473e5b0 into develop Aug 21, 2024
7 checks passed
@JcMinarro JcMinarro deleted the fix/previewdata-r8 branch August 21, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees

@skydoves skydoves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skydoves @JcMinarro