fix: asset library issues #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
khushal87
reviewed
Nov 26, 2024
khushal87
reviewed
Nov 26, 2024
khushal87
previously approved these changes
Nov 26, 2024
# Conflicts: # examples/SampleApp/ios/Podfile.lock
khushal87
dismissed
their stale review
Found some bugs when we were in the call. Let me know when they are solved and I can review again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR fixes the Expo media library and RN camera roll issues on new architecture.
In order to normalize all asset paths and uris, we take advantage of both camera roll and media library in their respective native bundles and get the local URIs of the assets we need. Done both for photos and videos.
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch