Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inverted unread indicator due to applied inverted styles #2889

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

khushal87
Copy link
Member

@khushal87 khushal87 commented Jan 10, 2025

This solution works on older and newer devices, android 33 and older, and also on >0.73 and <0.73.

Images attached
RN >0.73 on all types of android device
Screenshot 2025-01-10 at 9 34 37 PM

RN <0.73 on all types of android devices
Screenshot 2025-01-10 at 9 36 04 PM

Fixes #2885

@Stream-SDK-Bot
Copy link
Contributor

Stream-SDK-Bot commented Jan 10, 2025

SDK Size

title develop branch diff status
js_bundle_size 463 KB 453 KB -10035 B 🚀

Copy link
Contributor

@isekovanic isekovanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look if things are indeed working fine for the usecases I mentioned in the comments, if everything's fine then feel free to go ahead ! 🚀

@khushal87 khushal87 merged commit ba07bf9 into V5 Jan 15, 2025
3 of 4 checks passed
@khushal87 khushal87 deleted the fix-inverted-message-components branch January 15, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants