fix: channel-pinning related improvements #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.43 kB (+0.12%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2602 +/- ##
==========================================
- Coverage 81.12% 81.09% -0.04%
==========================================
Files 448 449 +1
Lines 9464 9489 +25
Branches 2312 2231 -81
==========================================
+ Hits 7678 7695 +17
- Misses 1423 1684 +261
+ Partials 363 110 -253 ☔ View full report in Codecov by Sentry. |
arnautov-anton
force-pushed
the
fix/channel-pinning-improvements
branch
from
cd560e7 to
ab0f5b2
Compare
khushal87
reviewed
Jan 22, 2025
arnautov-anton
force-pushed
the
fix/channel-pinning-improvements
branch
3 times, most recently
from
17c4e7f to
9e43ca8
Compare
arnautov-anton
force-pushed
the
fix/channel-pinning-improvements
branch
from
3442e1f to
0ce789b
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
## [12.9.0](v12.8.2...v12.9.0) (2025-01-27) ### Bug Fixes * channel-pinning related improvements ([#2602](#2602)) ([9f41a4c](9f41a4c)), closes [/github.com//issues/2595#issuecomment-2569118691](https://github.com/GetStream//github.com/GetStream/stream-chat-react/issues/2595/issues/issuecomment-2569118691) * import execSync ([#2616](#2616)) ([3801375](3801375)) ### Features * add prop disabled to ChatAutoComplete props ([#2617](#2617)) ([8b686fe](8b686fe))
|
🎉 This PR is included in version 12.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Adjust certain conditions to match behavior of the RN implementation, add missing handler for the
notification.added_to_channel.Notable Changes
notification.added_to_channelis being handled properly (considers pinned channels)sortis an object andpinned_atis first in chronological order of property creation{ pinned_at: 1 | -1 }then pinned channels are considered (bug: channel list not updated after pinning a channel #2595 (comment))Related PR: GetStream/stream-chat-js#1430