Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests work on iOS 17 #356

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Make tests work on iOS 17 #356

merged 3 commits into from
Sep 7, 2023

Conversation

testableapple
Copy link
Contributor

@testableapple testableapple commented Aug 24, 2023 •
edited
Loading

🔗 Issue Link

Resolve https://github.com/GetStream/ios-issues-tracking/issues/507

🎯 Goal

Make tests work on iOS 17

🛠 Implementation

  • Bump iOS and Xcode versions on all affected workflows
  • Resolve errors and warnings in the project
  • Update snapshots

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@testableapple testableapple added the 🔧 WIP A PR that is Work In Progress label Aug 24, 2023
@github-actions
Copy link

github-actions bot commented Aug 24, 2023 •
edited
Loading

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@testableapple testableapple marked this pull request as ready for review September 5, 2023 18:28
@testableapple testableapple requested a review from a team as a code owner September 5, 2023 18:28
@testableapple testableapple added 🤖 CI/CD Any work related to CI/CD and removed 🔧 WIP A PR that is Work In Progress labels Sep 5, 2023
martinmitrevski
martinmitrevski reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments, I think it's best to wait for GM before merging. From the snapshots, it seems the font changed a bit on iOS 17.

.github/workflows/cron-checks.yml Show resolved Hide resolved
.github/workflows/cron-checks.yml
# - ios: 17.0
# xcode: 15.0
# os: macos-13
# device: "iPhone 14 Pro Max"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we use iPhone 14 Pro so far?

Copy link
Contributor Author

@testableapple testableapple Sep 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, these are cron checks, just copy-pasted logic from the main repo to align the environment. But device name is essential only for Snapshot tests, for other ones it's good to test on different devices to cover more scenarios.

.github/workflows/smoke-checks.yml Show resolved Hide resolved
StreamChatSwiftUITests/Tests/ChatChannel/MessageListView_Tests.swift Show resolved Hide resolved
StreamChatSwiftUITests/Tests/ChatChannel/ReactionsUsersView_Tests.swift Outdated Show resolved Hide resolved
martinmitrevski
martinmitrevski approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but first pls check the failing tests

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

75.0% 75.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@testableapple testableapple merged commit 08128d4 into main Sep 7, 2023
7 of 8 checks passed
@testableapple testableapple deleted the ios17/tests branch September 7, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testableapple @martinmitrevski