Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI experience #370

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Improve CI experience #370

merged 3 commits into from
Oct 5, 2023

Conversation

testableapple
Copy link
Contributor

🔗 Issue Links

Resolve https://github.com/GetStream/ios-issues-tracking/issues/513

🎯 Goal

  • - Cache SPM depenencies
  • - Cache iOS Runtimes
  • - Build StreamChat and StreamChatUI only once, and then use it for all apps and targets that need them
  • - Build Test App only once
  • - Do not bootstrap where it's not required

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

gif

@testableapple testableapple force-pushed the ci/cache-everything branch 3 times, most recently from 6a79f5a to fdcd9e2 Compare September 28, 2023 15:40
@testableapple testableapple marked this pull request as ready for review September 29, 2023 09:37
@testableapple testableapple requested a review from a team as a code owner September 29, 2023 09:37
martinmitrevski
martinmitrevski approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👏 Just one question about the update of the xcodeproj.

StreamChatSwiftUI.xcodeproj/project.pbxproj
@@ -2233,6 +2233,7 @@
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = EHV7XZLAHA;
GCC_OPTIMIZATION_LEVEL = s;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this and which target it's exactly changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is StreamChatSwiftUITestsApp and StreamChatSwiftUITestsAppTests in Debug configuration. This should speed up the building process a bit.

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

57.6% 57.6% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@testableapple testableapple merged commit 63e1369 into main Oct 5, 2023
9 of 10 checks passed
@testableapple testableapple deleted the ci/cache-everything branch October 5, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testableapple @martinmitrevski