Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark unread and jump to unread #406

Merged
merged 15 commits into from
Dec 8, 2023
Merged

Mark unread and jump to unread #406

merged 15 commits into from
Dec 8, 2023

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Link

Jira or Github issue link, if applicable.

🎯 Goal

Describe why we are making this change.

🛠 Implementation

Provide a description of the implementation.

🧪 Testing

Describe the steps how this change can be tested (or why it can't be tested).

🎨 Changes

Add relevant screenshots or videos showcasing the changes.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@martinmitrevski martinmitrevski requested a review from a team as a code owner December 6, 2023 14:47
@martinmitrevski martinmitrevski marked this pull request as draft December 6, 2023 14:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

testableapple
testableapple approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@testableapple testableapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@martinmitrevski martinmitrevski marked this pull request as ready for review December 8, 2023 09:52
@martinmitrevski martinmitrevski merged commit 23fce24 into main Dec 8, 2023
2 of 3 checks passed
@martinmitrevski martinmitrevski deleted the jump-to-unread branch December 8, 2023 10:20
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

67.7% 67.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testableapple testableapple testableapple approved these changes

Assignees
No one assigned
Labels
🤞 Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinmitrevski @testableapple