Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice recording messages now use the standard message modifier #441

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Link

Resolves #440.

🎯 Goal

Describe why we are making this change.

🛠 Implementation

Provide a description of the implementation.

🧪 Testing

Describe the steps how this change can be tested (or why it can't be tested).

🎨 Changes

Add relevant screenshots or videos showcasing the changes.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

Copy link

sonarcloud bot commented Feb 27, 2024

Copy link
Contributor

@testableapple testableapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@martinmitrevski martinmitrevski merged commit ebd450b into main Feb 27, 2024
10 checks passed
@martinmitrevski martinmitrevski deleted the voice-recording-cell-fix branch February 27, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VoiceRecordingView should use viewfactory's bubble modifier
2 participants