Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue in the demo app when switching users #448

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

martinmitrevski
Copy link
Contributor

🎯 Goal

When we logout, we should set the channel list controller to nil, it's causing a caching issue on the SwiftUI view otherwise.

🛠 Implementation

Provide a description of the implementation.

🧪 Testing

Describe the steps how this change can be tested (or why it can't be tested).

🎨 Changes

Add relevant screenshots or videos showcasing the changes.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@martinmitrevski martinmitrevski requested a review from a team as a code owner March 7, 2024 08:46
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@martinmitrevski martinmitrevski merged commit 2a02b9b into main Mar 7, 2024
9 of 10 checks passed
@martinmitrevski martinmitrevski deleted the demo-app-fix branch March 7, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants