Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source tag to podspec #503

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Add source tag to podspec #503

merged 3 commits into from
Jun 5, 2024

Conversation

testableapple
Copy link
Contributor

🔗 Issue Link

Resolve #501

🛠 Implementation

  • Added source tag to the main podspec
  • Refactored both podspecs

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@testableapple testableapple added the 🤖 CI/CD Any work related to CI/CD label Jun 5, 2024
@testableapple testableapple requested a review from a team as a code owner June 5, 2024 14:11
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@testableapple testableapple merged commit 9e81f19 into main Jun 5, 2024
8 of 10 checks passed
@testableapple testableapple deleted the ci/add-source-tag-to-podspec branch June 5, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Podspec Missing Tag Specification Causes Installation to Default to Main Branch
2 participants
@testableapple @martinmitrevski