Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added thread replies shown in channel indicator #518

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Link

Resolves https://github.com/GetStream/ios-issues-tracking/issues/657.

🎯 Goal

When you use the "Show in channel" option for thread replies, there was no visual indicator in the message list to indicate this. This PR fixes it.

🛠 Implementation

Exposed new factory method for this view, and reused the existing MessageRepliesView.

🧪 Testing

Send a message from a thread with the checkmark to send it to the channel as well.

🎨 Changes

Add relevant screenshots or videos showcasing the changes.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@martinmitrevski martinmitrevski requested a review from a team as a code owner June 18, 2024 14:40
Copy link

sonarcloud bot commented Jun 18, 2024

@martinmitrevski martinmitrevski merged commit 2f07f70 into main Jun 19, 2024
10 checks passed
@martinmitrevski martinmitrevski deleted the thread-replies-indicator branch June 19, 2024 07:35
@martinmitrevski martinmitrevski mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants