Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping image and video attachments in the same message #525

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Link

Resolves https://stream-io.atlassian.net/browse/PBE-4343?atlOrigin=eyJpIjoiNWE3NzBlZThiZDUwNGNiM2IzNTRlODBkYmI5ZTFiZDQiLCJwIjoiaiJ9.

🎯 Goal

Images and videos should be part of the same message.

🛠 Implementation

Refactored the existing image attachment view to support videos. Kept the existing ones for backward compatibility.

🧪 Testing

Try different combinations of images and videos (and single ones too).

🎨 Changes

Add relevant screenshots or videos showcasing the changes.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@martinmitrevski martinmitrevski requested a review from a team as a code owner June 25, 2024 15:46
@laevandus
Copy link
Contributor

I tried the branch and works well.
What I observed was that video attachments are rendered as first items always in-spite of the order how I picked them (pick images first, then videos).

@martinmitrevski
Copy link
Contributor Author

I tried the branch and works well. What I observed was that video attachments are rendered as first items always in-spite of the order how I picked them (pick images first, then videos).

Yes, that's fine for now. Otherwise we would need to fetch all type erased attachments and cast them, so it might slow things down. We can revisit if there are complaints.

Copy link

sonarcloud bot commented Jun 26, 2024

@martinmitrevski martinmitrevski enabled auto-merge (squash) June 26, 2024 10:14
@martinmitrevski martinmitrevski merged commit a9bc868 into develop Jun 26, 2024
10 checks passed
@martinmitrevski martinmitrevski deleted the layout-media-attachments branch June 26, 2024 10:38
@martinmitrevski martinmitrevski mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants