Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing quoted messages did not refresh the message list #536

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Editing quoted messages did not refresh the message list #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bf1228
Editing quoted messages did not refresh the message list
laevandus Jul 4, 2024
b3bc28f
Set branch back to develop
laevandus Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Sources/StreamChatSwiftUI/Utils/MessageCachingUtils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ class MessageCachingUtils {
}

func quotedMessage(for message: ChatMessage) -> ChatMessage? {
if StreamRuntimeCheck._isDatabaseObserverItemReusingEnabled {
return message.quotedMessage
}

if checkedMessageIds.contains(message.id) {
return nil
}
Expand Down
11 changes: 11 additions & 0 deletions StreamChatSwiftUITests/Tests/ChatChannel/MessageCachingUtils_Tests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@ class MessageCachingUtils_Tests: StreamChatTestCase {
author: author
)
)

private var initialReusingState = false

override func setUpWithError() throws {
initialReusingState = StreamRuntimeCheck._isDatabaseObserverItemReusingEnabled
StreamRuntimeCheck._isDatabaseObserverItemReusingEnabled = false
}

override func tearDownWithError() throws {
StreamRuntimeCheck._isDatabaseObserverItemReusingEnabled = initialReusingState
}

func test_messageCachingUtils_authorId() {
// Given
Expand Down
Loading