Use fileCDN with video attachments #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,31 +34,43 @@ public final class DefaultVideoPreviewLoader: VideoPreviewLoader { | |||
| NotificationCenter.default.removeObserver(self) | |||
| } | |||
|
|
|||
| public func loadPreviewForVideo(at url: URL, completion: @escaping (Result<UIImage, Error>) -> Void) { | |||
| public func loadPreviewForVideo(at url: URL, fileCDN: FileCDN, completion: @escaping (Result<UIImage, Error>) -> Void) { | |||
There was a problem hiding this comment.
this would be a breaking change - can you instead inject the FileCDN via our DI mechanism? (@Injected)
There was a problem hiding this comment.
No problem, will get it updated. Thanks for the prompt reviews!
bpollman
force-pushed
the
filecdn-video
branch
from
95ea66f
to
00fd3b6
Compare
martinmitrevski
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
Jira or Github issue link, if applicable.
🎯 Goal
We need a way for all attachment URL's to be intercepted and adjusted/signed.
🛠 Implementation
This update adds FileCDN handling to all video attachment touch points primarily via the:
VideoPreviewLoaderfor thumbnailsStreamVideoPlayerandVideoPlayerViewAlso make a few style & comment clean ups from previous FileCDN PR.
🧪 Testing
Added basic tests
🎨 Changes
Add relevant screenshots or videos showcasing the changes.
☑️ Checklist