Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with photo attachment picker not displaying #640

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

martinmitrevski
Copy link
Contributor

🎯 Goal

Seems like on iOS 18 the overlay updates are triggered differently, causing the checkmark in the photo picker not to display when tapping.

🛠 Implementation

Added an id identifier to be explicit about this.

🧪 Testing

Open the photo picker and tap on some images.

🎨 Changes

Add relevant screenshots or videos showcasing the changes.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@martinmitrevski martinmitrevski requested a review from a team as a code owner November 5, 2024 12:23
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.99 MB 7.99 MB 0 KB 🟢

1 similar comment
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Nov 5, 2024

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.99 MB 7.99 MB 0 KB 🟢

@martinmitrevski martinmitrevski enabled auto-merge (squash) November 5, 2024 12:43
Copy link

sonarcloud bot commented Nov 5, 2024

@martinmitrevski martinmitrevski merged commit 56c1f22 into develop Nov 5, 2024
11 checks passed
@martinmitrevski martinmitrevski deleted the checkmark-picker branch November 5, 2024 13:43
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants