Channel Info: Only show Add Users button if user has permission to do so #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e showing "Add Users" button
|
Hi @bpollman! Thank you for the PR again, we'll handle it from here 👍 |
nuno-vieira
changed the base branch from
develop
to
fix/use-member-permissions-in-channel-info-view
nuno-vieira
merged commit d7f283a
into
GetStream:fix/use-member-permissions-in-channel-info-view
5 of 9 checks passed
4 tasks
nuno-vieira
added a commit
that referenced
this pull request
Nov 12, 2024
…ns (#651) * Channel Info: Add Check for `update-channel-members` permission before showing "Add Users" button (#650) * Update CHANGELOG.md * Fix swiftformat * Fix test on channel info view --------- Co-authored-by: Ben Pollman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
Jira or Github issue link, if applicable.
🎯 Goal
Hide the add user button if the action will fail
🛠 Implementation
Provide a description of the implementation.
🧪 Testing
Added users tests to ensure DM's and permissions check works
🎨 Changes
Add relevant screenshots or videos showcasing the changes.
☑️ Checklist