Reconnect v2 #1219
Draft
Reconnect v2 #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/StreamVideoImpl.kt # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/socket/PersistentSocket.kt
# Conflicts: # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/socket/CoordinatorSocket.kt
# Conflicts: # stream-video-android-core/api/stream-video-android-core.api # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/socket/PersistentSocket.kt # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/socket/SfuSocket.kt
# Conflicts: # stream-video-android-core/api/stream-video-android-core.api # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/internal/network/NetworkStateProvider.kt # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/utils/AndroidUtils.kt
# Conflicts: # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/socket/PersistentSocket.kt
# Conflicts: # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/StreamVideoImpl.kt # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/utils/DebugInfo.kt
# Conflicts: # stream-video-android-ui-core/src/main/kotlin/io/getstream/video/android/ui/common/StreamCallActivity.kt
# Conflicts: # gradle/libs.versions.toml # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/ClientState.kt # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/service/CallService.kt
# Conflicts: # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/RtcSession.kt
demo-app/src/main/kotlin/io/getstream/video/android/ui/call/CallScreen.kt
Outdated
Show resolved
Hide resolved
demo-app/src/main/kotlin/io/getstream/video/android/ui/menu/base/DynamicMenu.kt
Show resolved
Hide resolved
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/Call.kt
Outdated
Show resolved
Hide resolved
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/Call.kt
Outdated
Show resolved
Hide resolved
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/Call.kt
Outdated
Show resolved
Hide resolved
| * If the connection is not alive anymore, an action to reconnect is postponed. | ||
| * In another case the healthCheck is postponed. | ||
| */ | ||
| private fun postponeHealthMonitor() { |
There was a problem hiding this comment.
what triggers the execution of the action, after it being postponed?
| fun nextInterval(consecutiveFailures: Int): Long | ||
| } | ||
|
|
||
| object ExponencialRetryInterval : RetryInterval { |
| internal open class CustomObjectDtoAdapter<Value : Any>(private val kClass: KClass<Value>) { | ||
|
|
||
| private companion object { | ||
| private const val EXTRA_DATA = "extraData" |
There was a problem hiding this comment.
shouldn't this be "custom"?
| } | ||
| } | ||
| } | ||
| // callListeners { listener -> listener.onDisconnected(cause = state.cause) } |
There was a problem hiding this comment.
can we remove this?
| @@ -71,7 +71,7 @@ func (x VideoLayerSetting_Priority) Number() protoreflect.EnumNumber { | |||
|
|
|||
| // Deprecated: Use VideoLayerSetting_Priority.Descriptor instead. | |||
| func (VideoLayerSetting_Priority) EnumDescriptor() ([]byte, []int) { | |||
| return file_video_sfu_event_events_proto_rawDescGZIP(), []int{26, 0} | |||
| return file_video_sfu_event_events_proto_rawDescGZIP(), []int{29, 0} | |||
There was a problem hiding this comment.
why do you keep this in the repo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Implement a reconnect v2 handling on Android.
🛠 Implementation details
New coordinator and sfu socket implementation.
Refactoring on the
RTCSessionandCallto better manage the connection state.