Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llc): manual quality selection #791

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Conversation

Brazol
Copy link
Contributor

@Brazol Brazol commented Nov 5, 2024

Adds APIs to manually override incoming video quality:

await call.setPreferredIncomingVideoResolution(VideoResolution(width: 640, height: 480), sessionIds: [ids]);

Specify preference for incoming video resolution. The preference will be matched as close as possible, but the actual resolution will depend on the video source quality and client network conditions. It will enable incoming video if it is previously disabled.

Passing null resolution clears previously set preferences.

Optionally specify session ids of the participants this preference has effect on. Affects all participants by default.

call.setIncomingVideoEnabled(false)

Enables or disables incoming video from all remote call participants, and clears any preference for preferred resolution.

screen-20241105-141406.mov

@Brazol Brazol requested a review from a team as a code owner November 5, 2024 14:02
Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brazol Brazol merged commit 0e698c2 into main Nov 6, 2024
5 checks passed
@Brazol Brazol deleted the feat/manual-quality-selection branch November 6, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants