Fix for issue #25 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check that template.ApplicationPolicies is non-null
|
Faced the problem too today, thanks you for the pull request! Very appreciated :) |
leechristensen
approved these changes
Jan 27, 2023
|
Looks good! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified in #25, when a template has no application policies the
Certify.Commands.Find.IsCertificateTemplateVulnerablefunction hits a null reference when accessingtemplate.applicationPoliciesvia theContains()method. This is used to check if a template is vulnerable because of an unsafe application policy.To fix this, added a nullity check on
template.applicationPolicies. If it is null then we consider this check as passing.