Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaked descriptions – part 3 #81

Merged
merged 9 commits into from
Feb 23, 2020
Merged

Tweaked descriptions – part 3 #81

merged 9 commits into from
Feb 23, 2020

Conversation

4Luke4
Copy link
Contributor

@4Luke4 4Luke4 commented Jan 20, 2020

No description provided.

@4Luke4
Copy link
Contributor Author

4Luke4 commented Jan 20, 2020

@lynxlynxlynx

It seems impossible to anchor a specific script trigger... I expected the following to work, but it isn't:
href="../../../scripting/triggers/bgeetriggers.htm#0x4037"

Which is the correct way?

@lynxlynxlynx
Copy link
Member

No, they don't have anchors or ids defined. You'd have to fix them first.

@4Luke4
Copy link
Contributor Author

4Luke4 commented Jan 20, 2020

You'd have to fix them first.

Do you mean something like this?
<div class="triggerHeader"><a name="0x4017">0x4017 Race(O:Object*,I:Race*Race)</a></div>

EDIT: Yes, that's correct.

– Fixed wrong offset references in some IDS files (e.g., SPECIFIC.IDS)
@lynxlynxlynx
Copy link
Member

Pretty sure it's enough for the div to have the same id, eg <div id="0x4010">. Also doesn't affect the style that way.

<ul>
<li>0 => Disabled</li>
<li>1 => Enabled</li>
</ul>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really!? Do you know why they negated the meaning for some of the games?

@lynxlynxlynx lynxlynxlynx linked an issue Feb 13, 2020 that may be closed by this pull request
@lynxlynxlynx lynxlynxlynx merged commit 9040775 into Gibberlings3:master Feb 23, 2020
@lynxlynxlynx
Copy link
Member

Thanks!

@4Luke4
Copy link
Contributor Author

4Luke4 commented Feb 25, 2020

Thanks!

You're welcome.

However:

  • some anchors in the EE version of STATS.IDS are broken (they work fine on my local copy...)
  • I added BDSTWEAP.2DA and 7EYES.2DA to 2da_bgee but they're not there...

@lynxlynxlynx
Copy link
Member

Is there a concrete anchor you can point me at?

The 2da list isn't generated (yet? #5 etc.), so you have to add them to the index manually:
https://github.com/Gibberlings3/iesdp/blob/master/files/2da/2da_bgee/index.htm

@4Luke4
Copy link
Contributor Author

4Luke4 commented Feb 28, 2020

Is there a concrete anchor you can point me at?

All opcode links in the EE file stats.htm (for instance, <a href="../../../_opcodes/op318-bgee.html">#318</a>)

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 6, 2020

That means that port is busy, likely by jekyll launched from another terminal tab, but it could be something else.
See sudo netstat -pnlt | grep 4000 for process pid, kill it.

Got this:
netstat: nlt: unknown or uninstrumented protocol

@burner1024
Copy link
Contributor

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 6, 2020

Probably mac version is different.
https://stackoverflow.com/questions/4421633/who-is-listening-on-a-given-tcp-port-on-mac-os-x#4421674

Done via lsof -nP -iTCP:4000 | grep LISTEN and kill -9 $(lsof -t -i :4000).

I got the IP and copy-pasted it into my browser. Some issues:

  1. During Generating... process, I got a lot of warnings of this type: warning: Using the last argument as keyword parameters is deprecated
  2. I cannot see the Opcodes page (see the attached scrennshot)
  3. Finally, this: ERROR `/favicon.ico' not found.

Opcodes

@lynxlynxlynx
Copy link
Member

Probably too new jekyll, 4.0 has breaking changes.

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 6, 2020

Probably too new jekyll, 4.0 has breaking changes.

Do you recommend a particular version?

@lynxlynxlynx
Copy link
Member

If you want to use the same as travis, it's from the 3.8 branch.

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 6, 2020

If you want to use the same as travis, it's from the 3.8 branch.

Correct syntax?

I uninstalled it via gem uninstall --user-install bundler jekyll and tried reinstalling via gem install --user-install bundler jekyll v3.8.6 and got this:

Successfully installed jekyll-4.0.0
Parsing documentation for jekyll-4.0.0
Installing ri documentation for jekyll-4.0.0
Done installing documentation for jekyll after 1 seconds
ERROR:  Could not find a valid gem 'v3.8.6' (>= 0) in any repository
2 gems installed

Why does it still mention v4.0.0?

@burner1024
Copy link
Contributor

Come on, you've got to put some effort. Your command says: "install gems 'bundler', 'jekyll' and 'v3.8.6'".
See gem install --help, https://stackoverflow.com/questions/17026441/how-to-install-a-specific-version-of-a-ruby-gem

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 6, 2020

Come on, you've got to put some effort....

Sorry man, I'm trying...

OK, I ran one command at a time, i.e.:

gem install --user-install bundler 
gem install --user-install jekyll -v 3.8.6   

After that, I ran jekyll serve --incremental again, but I'm having the same issues as before...

Everything else seems to work fine...

@burner1024
Copy link
Contributor

burner1024 commented Apr 6, 2020

@4Luke4 did you uninstall 4.0? If not, it's probably still being used for generation.
@lynxlynxlynx maybe add Gemfile/lock, to ensure versions are the same?

@lynxlynxlynx
Copy link
Member

Might be easier to just go for 4 compat and change those iterators.

@burner1024
Copy link
Contributor

4 has broken where filter, not sure if they fixed it yet.

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 6, 2020

@4Luke4 did you uninstall 4.0? If not, it's probably still being used for generation.

Yes, I ran gem uninstall --user-install bundler jekyll. The only thing that cannot be uninstalled (apparently) is the gem bundler:

~ % gem uninstall --user-install bundler jekyll
Gem 'jekyll' is not installed
Gem bundler-2.1.2 cannot be uninstalled because it is a default gem

Is that somewhat relevant?

@burner1024
Copy link
Contributor

Is that somewhat relevant?

No, looks good. You can check installed gems with gem list.

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 6, 2020

Is that somewhat relevant?

No, looks good. You can check installed gems with gem list.

So what's the issue then? Why is it that difficult?

@lynxlynxlynx
Copy link
Member

So when you run jekyll, what version is running?

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 6, 2020

So when you run jekyll, what version is running?

I reverted back to the latest version (i.e., v4.0.0...)

Generating... 
/Users/USERNAME/.gem/ruby/2.7.0/gems/jekyll-4.0.0/lib/jekyll/convertible.rb:41: warning: Using the last argument as keyword parameters is deprecated
...
Auto-regeneration: enabled for '/Users/USERNAME/Desktop/iesdp'
    Server address: http://127.0.0.1:4000/iesdp/
  Server running... press ctrl-c to stop.
~ % which jekyll
/Users/USERNAME/.gem/ruby/2.7.0/bin/jekyll
~ % jekyll -v
jekyll 4.0.0

@lynxlynxlynx
Copy link
Member

Like we pointed out, that can't work.

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 6, 2020

Like we pointed out, that can't work.

What are you referring to exactly? I've already tried with a version from 3.8 branch (i.e., v3.8.6), but it didn't work...

@lynxlynxlynx
Copy link
Member

Yes, but it should, while 4.0 is known not to work for EVERYONE.

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 6, 2020

Yes, but it should, while 4.0 is known not to work for EVERYONE.

OK, I ran iesdp % jekyll serve --incremental after deleting _site, .sass-cache and .jekyll-metadata from my local copy and now everything is working fine – Using jekyll v3.8.6 (I still get those warnings and ERROR `/favicon.ico' not found., but they're probably harmless...)

@burner1024, @lynxlynxlynx Thank you very much for your assistance!

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 6, 2020

Another question: Do I need to manually delete _site every time I build it? I noticed that new changes did not take effect...

@burner1024
Copy link
Contributor

Another question: Do I need to manually delete _site every time I build it? I noticed that new changes did not take effect...

You shouldn't need to, but note it takes a while to build the site (~ 1 minute on my machine).

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 6, 2020

Another question: Do I need to manually delete _site every time I build it? I noticed that new changes did not take effect...

You shouldn't need to, but note it takes a while to build the site (~ 1 minute on my machine).

Yeah, I noticed it takes a while, but if I don't do it, then new changes won't take effect... Am I missing something?

@lynxlynxlynx
Copy link
Member

Are you refreshing the page in the browser?

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 7, 2020

Are you refreshing the page in the browser?

Yes, it isn't working...

@burner1024
Copy link
Contributor

well, you can try without --incremental

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 7, 2020

well, you can try without --incremental

So, this is odd... The Terminal window clearly rebuilds the site upon making changes – The first time I got ...done in 60.xxx seconds; after making a little change, I got ...done in 8.892394 seconds.

But if I refresh the webpage, new changes do not take effect...
Don't want to remove the --incremental flag due to performance issues and the --watch flag should be the default for serve since 2.4.0...

@lynxlynxlynx
Copy link
Member

Try opening the developer console in the browser, make sure having it open disables caching (not sure if on by default) and have it open while developing. Reloading the page will then ignore any browser caching.

@4Luke4
Copy link
Contributor Author

4Luke4 commented Apr 7, 2020

Try opening the developer console in the browser, make sure having it open disables caching (not sure if on by default) and have it open while developing. Reloading the page will then ignore any browser caching.

Still nothing... I clicked on "Show Javascript Console", then "Reload the page ignoring cache"...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EE/Ex saving throw bits
3 participants