[Core] Add simple serving feature with Uvicorn #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tdeborde <[email protected]>
Co-authored-by: tdeborde <[email protected]>
Co-authored-by: tdeborde <[email protected]>
|
LGTM |
nflan
approved these changes
Jun 20, 2024
| from gigax.step import NPCStepper | ||
|
|
||
| load_dotenv() | ||
|
|
There was a problem hiding this comment.
Suggested change
| # Logging configuration |
| ) | ||
|
|
||
|
|
||
| logger = logging.getLogger("uvicorn") |
There was a problem hiding this comment.
Suggested change
| logger = logging.getLogger("uvicorn") |
|
|
||
| fastapi_logger.handlers = logging.getLogger("gunicorn.error").handlers | ||
| logging.basicConfig(level=logging.INFO, handlers=[logging.StreamHandler(sys.stdout)]) | ||
|
|
There was a problem hiding this comment.
Suggested change
| logger = logging.getLogger("uvicorn") | |
|
|
||
|
|
||
| logger = logging.getLogger("uvicorn") | ||
| logging.basicConfig(level=logging.INFO) |
There was a problem hiding this comment.
Are you sure that we need this line that is similar to the line 25?
|
|
||
|
|
||
| logger = logging.getLogger("uvicorn") | ||
| logging.basicConfig(level=logging.INFO) |
There was a problem hiding this comment.
Suggested change
| logging.basicConfig(level=logging.INFO) |
| logger = logging.getLogger("uvicorn") | ||
| logging.basicConfig(level=logging.INFO) | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| # Exception handler for validation errors |
| content=content, status_code=status.HTTP_422_UNPROCESSABLE_ENTITY | ||
| ) | ||
|
|
||
|
|
| items: list[Item] | ||
| events: list[CharacterAction] | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| # Endpoint for stepping the character |
| events=request.events, | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| # Health check endpoint |
| async def health_check(): | ||
| return {"status": "ok"} | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make usage of the lib easier from a game engine, add a simple server using Uvicorn.
Single endpoint for now, to update an NPC.
PR Checklist (Click to Expand)
Thank you for your contribution to gigax! Before submitting the pull request, please ensure the PR meets the following criteria. This helps gigax maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Model]for adding a new model or improving an existing model. Model name should appear in the title.[Core]for changes in the core gigax logic[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
./testsfolder in the rpo.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes, we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-requiredand might not go through the PR.What to Expect for the Reviews
The goal of the gigax team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the gigax team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to gigax.